Add support to get device serial from system BIOS table #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support to get device serial from system BIOS table. linux-client required elevated privileges. Use 'sudo' to execute. Signed-off-by: Shrikant Temburwar <shrikant.temburwar@intel.com>
KiranSukhavasi
previously approved these changes
Nov 10, 2023
…table Signed-off-by: Shrikant Temburwar <shrikant.temburwar@intel.com>
Signed-off-by: Shrikant Temburwar <shrikant.temburwar@intel.com>
KiranSukhavasi
approved these changes
Nov 13, 2023
DukeDavis12
approved these changes
Nov 13, 2023
v-vasavi
approved these changes
Nov 13, 2023
shrikant1407
commented
Nov 17, 2023
| @@ -69,20 +69,73 @@ static int read_fill_modelserial(void) | |||
| uint8_t def_model_sz = 0; | |||
| size_t fsize = 0; | |||
|
|
|||
| #if defined(GET_DEV_SERIAL) | |||
| int strcmp_res = -1; | |||
| char temp_device_serial[MAX_DEV_SERIAL_SZ]; | |||
There was a problem hiding this comment.
TO-DO: make it const
| // Get device serial number | ||
| int get_device_serial(char *serial_buff) | ||
| { | ||
| FILE *fp; |
There was a problem hiding this comment.
Please do input check for serial_buff before using it. Do it every place
| { | ||
| FILE *fp; | ||
| char *cmd = "dmidecode -s system-serial-number"; | ||
| int out_sz; |
There was a problem hiding this comment.
Add const for cmd variable ..As this value wouldnt change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support to get device serial from system BIOS table.
linux-client required elevated privileges. Use 'sudo' to execute.