From 0412500a82e252a16577a5dd84779ccb3796699d Mon Sep 17 00:00:00 2001 From: Rod Vagg Date: Thu, 1 Sep 2022 17:15:04 +1000 Subject: [PATCH] doc: make it clear InlineBuilder isn't recommended i.e. don't copypasta this for your filecoin deal prep --- car/car_offset_writer_test.go | 1 + itests/framework/framework.go | 2 +- testutil/car.go | 1 + transport/httptransport/http_transport_test.go | 1 + 4 files changed, 4 insertions(+), 1 deletion(-) diff --git a/car/car_offset_writer_test.go b/car/car_offset_writer_test.go index 0ad70fa20..bd3091223 100644 --- a/car/car_offset_writer_test.go +++ b/car/car_offset_writer_test.go @@ -244,6 +244,7 @@ func DAGImport(dserv format.DAGService, fi io.Reader) (format.Node, error) { Maxlinks: 1024, RawLeaves: true, + // NOTE: InlineBuilder not recommended, we are using this to test identity CIDs CidBuilder: cidutil.InlineBuilder{ Builder: prefix, Limit: 32, diff --git a/itests/framework/framework.go b/itests/framework/framework.go index 5bd62c441..770e8f0c2 100644 --- a/itests/framework/framework.go +++ b/itests/framework/framework.go @@ -59,7 +59,7 @@ import ( unixfile "github.com/ipfs/go-unixfs/file" "github.com/ipld/go-car" "github.com/libp2p/go-libp2p" - "github.com/libp2p/go-libp2p-core/host" + "github.com/libp2p/go-libp2p/core/host" "github.com/multiformats/go-multihash" "github.com/stretchr/testify/require" "golang.org/x/sync/errgroup" diff --git a/testutil/car.go b/testutil/car.go index 6c8d7071b..3e85a72b7 100644 --- a/testutil/car.go +++ b/testutil/car.go @@ -139,6 +139,7 @@ func WriteUnixfsDAGTo(path string, into ipldformat.DAGService) (cid.Cid, error) params := ihelper.DagBuilderParams{ Maxlinks: unixfsLinksPerLevel, RawLeaves: true, + // NOTE: InlineBuilder not recommended, we are using this to test identity CIDs CidBuilder: cidutil.InlineBuilder{ Builder: prefix, Limit: 126, diff --git a/transport/httptransport/http_transport_test.go b/transport/httptransport/http_transport_test.go index 0683f83ca..b5b0f1b2d 100644 --- a/transport/httptransport/http_transport_test.go +++ b/transport/httptransport/http_transport_test.go @@ -509,6 +509,7 @@ func dagImport(dserv format.DAGService, fi io.Reader) (format.Node, error) { Maxlinks: 1024, RawLeaves: true, + // NOTE: InlineBuilder not recommended, we are using this to test identity CIDs CidBuilder: cidutil.InlineBuilder{ Builder: prefix, Limit: 32,