Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrader: record checksum for integrity checks #25

Open
raulk opened this issue Jul 5, 2021 · 2 comments
Open

upgrader: record checksum for integrity checks #25

raulk opened this issue Jul 5, 2021 · 2 comments
Milestone

Comments

@raulk
Copy link
Member

raulk commented Jul 5, 2021

For safety, record the checksum of a transient in shard persistence every time the shard goes into Available or Serving state.

Expose the checksum to the mount.Upgrader, so that when the mount needs to be redownloaded, it can perform an integritiy check.

We gotta be careful about recording an invalid checksum though. This can be a footgun if we get it wrong (e.g. recording a bad checksum as good will make future correct downloads error out).

@raulk raulk added this to the v0.1 milestone Jul 5, 2021
@aarshkshah1992
Copy link
Contributor

@raulk This too is something that can go in post-M1 and can be removed from the 0.1 Milestone.

@raulk
Copy link
Member Author

raulk commented Jul 6, 2021

There's plenty of time to get this in by M1, and it's net positive for stability.

@raulk raulk modified the milestones: v0.1, v0.2 Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants