Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DX Streamline] Add mechanism so PR titles conform to repo standard #12148

Open
BigLep opened this issue Jun 25, 2024 · 1 comment
Open

[DX Streamline] Add mechanism so PR titles conform to repo standard #12148

BigLep opened this issue Jun 25, 2024 · 1 comment
Labels
good first issue Good for newcomers
Milestone
DX-Streamline

Comments

@BigLep
Copy link
Member

BigLep commented Jun 25, 2024

Done Criteria

  1. PR creators get feedback if their PR title doesn't match the repo convention
  2. PR merges are blocked by default if the convention isn't followed

Why Important

  1. Consistency makes it easier when spotting for certain changes when going through the commit history.
  2. Prevents sloppy titles from making it into the commit history

User/Customer

  1. Maintainers
  2. Contributors

Notes

This most recently happened with 1e8bc10 where #12139 was checked in with the title "rough draft".
@BigLep BigLep added this to the DX-Streamline milestone Jun 25, 2024
@galargh
Copy link
Contributor

galargh commented Jun 28, 2024

It might be a good idea to handle the commit message conformance as well if the team feels the need for it

@rjan90 rjan90 added the good first issue Good for newcomers label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
FilOz
Status: 🐱Todo
Milestone
DX-Streamline
Development

No branches or pull requests
3 participants
@BigLep @galargh @rjan90