Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DX Streamline] Create draft GitHub releases on PRs modifying version.go #12163

Closed
galargh opened this issue Jun 27, 2024 · 1 comment · Fixed by #12096
Closed

[DX Streamline] Create draft GitHub releases on PRs modifying version.go #12163

galargh opened this issue Jun 27, 2024 · 1 comment · Fixed by #12096
Milestone

Comments

@galargh
Copy link
Contributor

galargh commented Jun 27, 2024

Problem to solve

Right now, a GitHub Release is created only after a PR modifying version.go is merged. This makes it impossible to verify the release or update its description prior to the merge. It also means that the release, on publish, is not yet ready for general public fully (lacking proper description).

Why Important

As soon as a really is out, it should be final - including the description part. By creating drafts on PRs, we'll be able to prepare all the aspects of the release prior to merge.

User/Customer

Lotus maintainers

Notes

Enabled by #12096

@galargh galargh added this to the DX-Streamline milestone Jun 27, 2024
@galargh
Copy link
Contributor Author

galargh commented Jun 27, 2024

When working on this, we should ensure that the replace_existing_draft setting of the goreleaser works as expected. Ideally, we want to be able to create a draft on a PR, be able to update it, and for those updates to survive any new pushes to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎉 Done
Development

Successfully merging a pull request may close this issue.

1 participant