-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lotus: let DisableNatPortMap default to true #12170
Comments
not sure if thats a bug or a feature request tbh |
i'd remove upnp features completely from the code. the gains are outweighed by the risks i think |
@f8-ptrk We will look into why this was set to false in the first place. But I think I do agree with you that there's no point in setting it to false if there's no strong reason to. |
Next step for this ticket is to investigate why That said, FilOz is currently not going to prioritise doing this investigation in Q3, and we have therefore put up a "Good First Issue" ticket on it. |
It defaults to false because it allows residential users to be dialled into. |
Checklist
Latest release
, the most recent RC(release canadiate) for the upcoming release or the dev branch(master), or have an issue updating to any of these.Lotus component
Describe the Bug
DisableNatPortMap
currently defaults tofalse
.This produces a lot of
WARN
level messages about upnp failures if the router isn't set up right. lotus seems not to be able to identify that it isn't able to perform the given task on the given device it runs upnp against and loops.Beyond that: it isn't recommended to enable upnp router sides without good reasons to do so. having
DisableNatPortMap
default tofalse
might encourage router settings that are unsecure or unable to be comprehended by the user in their full impact.The text was updated successfully, but these errors were encountered: