Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include RPC API versioning as part of release process #12210

Open
rvagg opened this issue Jul 11, 2024 · 0 comments
Open

Include RPC API versioning as part of release process #12210

rvagg opened this issue Jul 11, 2024 · 0 comments

Comments

@rvagg
Copy link
Member

rvagg commented Jul 11, 2024

lotus/api/version.go

Lines 56 to 62 in 7ea0e6c

var (
FullAPIVersion0 = newVer(1, 5, 0)
FullAPIVersion1 = newVer(2, 3, 0)
MinerAPIVersion0 = newVer(1, 5, 0)
WorkerAPIVersion0 = newVer(1, 7, 0)
)

TIL about this, and it hasn't been bumped since 2022, and that's not great. IT should be bumped if the external API has been broken, added to, or something has been fixed about the way they work. Proper semver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🐱 Todo
Development

No branches or pull requests

1 participant