various bug fixes (#1973)

* minor cleanups

* Revert "fix dispatch logic for key bindings so that it executes for the correct command key (#1970)"

This reverts commit 4cc25f4.

* add changeset

* pure ide: fix copy/paste hotkey on windows

* pure ide: add hotkey Ctrl+D for deleting line

* minor fixes

* bump dependencies

* terminal: support context menu for copy command

* pure ide: improve hotkey experience with text search

* shared: fix a problem with StopWatch.elapsed not accurately calculated

* BREAKING: moved TelemetryService and EventNotifierService to @finos/legend-application

* timer: account for app usage interruption when reporting timing metrics

* query-builder: ensure ag-grid theme customization is respected

* bump dependencies

* block Ctrl+Shift+N native platform hotkey

* hokeys: fix an issue with hotkeys being triggered twice

* upgrade Yarn and add dependencies upgrade guide

* bump dependencies

.changeset/famous-camels-joke.md

@@ -0,0 +1,39 @@
+---
+'@finos/legend-application-pure-ide-deployment': patch
+'@finos/legend-application-taxonomy-deployment': patch
+'@finos/legend-extension-dsl-persistence-cloud': patch
+'@finos/legend-application-taxonomy-bootstrap': patch
+'@finos/legend-application-studio-deployment': patch
+'@finos/legend-extension-store-service-store': patch
+'@finos/legend-application-query-deployment': patch
+'@finos/legend-application-studio-bootstrap': patch
+'@finos/legend-extension-format-json-schema': patch
+'@finos/legend-application-query-bootstrap': patch
+'@finos/legend-extension-store-relational': patch
+'@finos/legend-extension-dsl-persistence': patch
+'@finos/legend-extension-store-flat-data': patch
+'@finos/legend-extension-dsl-data-space': patch
+'@finos/legend-extension-format-graphql': patch
+'@finos/legend-extension-format-morphir': patch
+'@finos/legend-extension-tracer-zipkin': patch
+'@finos/legend-extension-dsl-diagram': patch
+'@finos/legend-extension-dsl-mastery': patch
+'@finos/legend-extension-dsl-service': patch
+'@finos/legend-application-pure-ide': patch
+'@finos/legend-application-taxonomy': patch
+'@finos/legend-application-studio': patch
+'@finos/legend-extension-dsl-text': patch
+'@finos/legend-application-query': patch
+'@finos/legend-query-builder': patch
+'@finos/legend-server-depot': patch
+'@finos/legend-application': patch
+'@finos/legend-server-sdlc': patch
+'@finos/legend-dev-utils': patch
+'@finos/stylelint-config-legend-studio': patch
+'@finos/legend-storage': patch
+'@finos/eslint-plugin-legend-studio': patch
+'@finos/legend-shared': patch
+'@finos/babel-preset-legend-studio': patch
+'@finos/legend-graph': patch
+'@finos/legend-art': patch
+---

.changeset/giant-rules-hear.md

@@ -0,0 +1,39 @@
+---
+'@finos/legend-application-pure-ide-deployment': patch
+'@finos/legend-application-taxonomy-deployment': patch
+'@finos/legend-extension-dsl-persistence-cloud': patch
+'@finos/legend-application-taxonomy-bootstrap': patch
+'@finos/legend-application-studio-deployment': patch
+'@finos/legend-extension-store-service-store': patch
+'@finos/legend-application-query-deployment': patch
+'@finos/legend-application-studio-bootstrap': patch
+'@finos/legend-extension-format-json-schema': patch
+'@finos/legend-application-query-bootstrap': patch
+'@finos/legend-extension-store-relational': patch
+'@finos/legend-extension-dsl-persistence': patch
+'@finos/legend-extension-store-flat-data': patch
+'@finos/legend-extension-dsl-data-space': patch
+'@finos/legend-extension-format-graphql': patch
+'@finos/legend-extension-format-morphir': patch
+'@finos/legend-extension-tracer-zipkin': patch
+'@finos/legend-extension-dsl-diagram': patch
+'@finos/legend-extension-dsl-mastery': patch
+'@finos/legend-extension-dsl-service': patch
+'@finos/legend-application-pure-ide': patch
+'@finos/legend-application-taxonomy': patch
+'@finos/legend-application-studio': patch
+'@finos/legend-extension-dsl-text': patch
+'@finos/legend-application-query': patch
+'@finos/legend-query-builder': patch
+'@finos/legend-server-depot': patch
+'@finos/legend-application': patch
+'@finos/legend-server-sdlc': patch
+'@finos/legend-dev-utils': patch
+'@finos/stylelint-config-legend-studio': patch
+'@finos/legend-storage': patch
+'@finos/eslint-plugin-legend-studio': patch
+'@finos/legend-shared': patch
+'@finos/babel-preset-legend-studio': patch
+'@finos/legend-graph': patch
+'@finos/legend-art': patch
+---

.changeset/gorgeous-dogs-judge.md

@@ -0,0 +1,39 @@
+---
+'@finos/legend-application-pure-ide-deployment': patch
+'@finos/legend-application-taxonomy-deployment': patch
+'@finos/legend-extension-dsl-persistence-cloud': patch
+'@finos/legend-application-taxonomy-bootstrap': patch
+'@finos/legend-application-studio-deployment': patch
+'@finos/legend-extension-store-service-store': patch
+'@finos/legend-application-query-deployment': patch
+'@finos/legend-application-studio-bootstrap': patch
+'@finos/legend-extension-format-json-schema': patch
+'@finos/legend-application-query-bootstrap': patch
+'@finos/legend-extension-store-relational': patch
+'@finos/legend-extension-dsl-persistence': patch
+'@finos/legend-extension-store-flat-data': patch
+'@finos/legend-extension-dsl-data-space': patch
+'@finos/legend-extension-format-graphql': patch
+'@finos/legend-extension-format-morphir': patch
+'@finos/legend-extension-tracer-zipkin': patch
+'@finos/legend-extension-dsl-diagram': patch
+'@finos/legend-extension-dsl-mastery': patch
+'@finos/legend-extension-dsl-service': patch
+'@finos/legend-application-pure-ide': patch
+'@finos/legend-application-taxonomy': patch
+'@finos/legend-application-studio': patch
+'@finos/legend-extension-dsl-text': patch
+'@finos/legend-application-query': patch
+'@finos/legend-query-builder': patch
+'@finos/legend-server-depot': patch
+'@finos/legend-application': patch
+'@finos/legend-server-sdlc': patch
+'@finos/legend-dev-utils': patch
+'@finos/stylelint-config-legend-studio': patch
+'@finos/legend-storage': patch
+'@finos/eslint-plugin-legend-studio': patch
+'@finos/legend-shared': patch
+'@finos/babel-preset-legend-studio': patch
+'@finos/legend-graph': patch
+'@finos/legend-art': patch
+---

.changeset/mean-parents-double.md

@@ -0,0 +1,6 @@
+---
+'@finos/legend-extension-dsl-data-space': patch
+'@finos/legend-application-taxonomy': patch
+'@finos/legend-application': patch
+'@finos/legend-shared': patch
+---

.changeset/olive-candles-fly.md

@@ -0,0 +1,5 @@
+---
+'@finos/legend-shared': major
+---
+
+**BREAKING CHANGE:** Moved `EventNotifierService` and `TelemetryService` to `@finos/legend-application` and reshaped `TelemetryService` as well as `TelemetryServicePlugin` to take a `setup()` method for instead of just allowing setting the user ID via `setUserId()`.

.changeset/small-ads-smile.md

@@ -0,0 +1,39 @@
+---
+'@finos/legend-application-pure-ide-deployment': patch
+'@finos/legend-application-taxonomy-deployment': patch
+'@finos/legend-extension-dsl-persistence-cloud': patch
+'@finos/legend-application-taxonomy-bootstrap': patch
+'@finos/legend-application-studio-deployment': patch
+'@finos/legend-extension-store-service-store': patch
+'@finos/legend-application-query-deployment': patch
+'@finos/legend-application-studio-bootstrap': patch
+'@finos/legend-extension-format-json-schema': patch
+'@finos/legend-application-query-bootstrap': patch
+'@finos/legend-extension-store-relational': patch
+'@finos/legend-extension-dsl-persistence': patch
+'@finos/legend-extension-store-flat-data': patch
+'@finos/legend-extension-dsl-data-space': patch
+'@finos/legend-extension-format-graphql': patch
+'@finos/legend-extension-format-morphir': patch
+'@finos/legend-extension-tracer-zipkin': patch
+'@finos/legend-extension-dsl-diagram': patch
+'@finos/legend-extension-dsl-mastery': patch
+'@finos/legend-extension-dsl-service': patch
+'@finos/legend-application-pure-ide': patch
+'@finos/legend-application-taxonomy': patch
+'@finos/legend-application-studio': patch
+'@finos/legend-extension-dsl-text': patch
+'@finos/legend-application-query': patch
+'@finos/legend-query-builder': patch
+'@finos/legend-server-depot': patch
+'@finos/legend-application': patch
+'@finos/legend-server-sdlc': patch
+'@finos/legend-dev-utils': patch
+'@finos/stylelint-config-legend-studio': patch
+'@finos/legend-storage': patch
+'@finos/eslint-plugin-legend-studio': patch
+'@finos/legend-shared': patch
+'@finos/babel-preset-legend-studio': patch
+'@finos/legend-graph': patch
+'@finos/legend-art': patch
+---

.changeset/tiny-horses-bathe.md

@@ -0,0 +1,5 @@
+---
+'@finos/legend-shared': patch
+---
+
+Fix a bug with `StopWatch` elapsed is not properly calculated.

.yarnrc.yml

@@ -24,4 +24,4 @@ plugins:
   - path: .yarn/plugins/@yarnpkg/plugin-workspace-tools.cjs
     spec: '@yarnpkg/plugin-workspace-tools'
 
-yarnPath: .yarn/releases/yarn-3.4.0.cjs
+yarnPath: .yarn/releases/yarn-3.4.1.cjs

docs/workflow/dependencies.md

@@ -24,7 +24,9 @@ Other parameters (no order implied) to consider are:
 
 ## Updating a dependency
 
-We can seem quiet _conservative_ about adding a new dependency, but when we already introduced it, we are very open to keeping it up-to-date. In fact, we encourage our team to check and update dependencies **as soon and as often as possible**. Of course, this applies to only `minor` and `patch` updates; for `major` version bumps, we need to evaluate the risk and effort as it can be considered as arduous as adding new dependencies.
+We can seem quiet _conservative_ about adding a new dependency, but when we already introduced it, we are very open to keeping it up-to-date. In fact, we encourage our team to check and update dependencies **as soon and as often as possible**. Of course, this applies to only `minor` and `patch` updates; for `major` version bumps, we need to evaluate the risk and effort as it can be considered as arduous as adding new dependencies
+
+> See this [guide](./upgrade-dependencies.md) for more details on dependencies upgrade procedure.
 
 ## When to move things to shared?
 

docs/workflow/upgrade-dependencies.md

@@ -0,0 +1,58 @@
+# Dependenies Upgrade Process
+
+## Libraries
+
+Run the interactive upgrade tool and follow our [strategy guide](./dependencies.md#updating-a-dependency) on dependencies upgrade to make your selection
+
+```sh
+yarn check:update
+```
+
+Update the package manifest cache/lock file
+
+```sh
+yarn fix:pkg
+```
+
+## Tools
+
+### Yarn
+
+```sh
+yarn set version stable
+```
+
+> NOTE: You might need to manually upgrade the plugins; we're not so sure if the above command also include upgrading the commands, follow this [guide](https://yarnpkg.com/features/plugins)
+
+### Node
+
+Update Node version enforeced in the root `package.json`
+
+```jsonc
+  ...
+  "engines": {
+    "node": ">=16.8.0"
+  }
+```
+
+Update Node version used for pipeline workflow
+
+```yml
+- name: Setup Node
+  uses: actions/setup-node@v3.6.0
+  with:
+    node-version: 16
+```
+
+### Docker
+
+Currently, we have fairly basic `Dockerfile` configurations, we just need to update the version of the base static web server
+
+```dockerfile
+FROM finos/legend-shared-server:0.23.3
+...
+```
+
+### Github Actions
+
+Currently, we set up [dependabot](https://docs.github.com/en/code-security/dependabot) to check for new updates of these tools (e.g. `actions/setup-node`, `actions/cache`, etc.). Just regularly check open PRs and merge them will do the work

fixtures/legend-mock-server/package.json

@@ -27,15 +27,15 @@
   },
   "dependencies": {
     "@fastify/cors": "8.2.0",
-    "fastify": "4.13.0"
+    "fastify": "4.14.1"
   },
   "devDependencies": {
     "@finos/legend-dev-utils": "workspace:*",
     "cross-env": "7.0.3",
     "eslint": "8.35.0",
-    "nodemon": "2.0.20",
+    "nodemon": "2.0.21",
     "npm-run-all": "4.1.5",
-    "rimraf": "4.1.2",
+    "rimraf": "4.3.1",
     "typescript": "4.9.5"
   }
 }

package.json

@@ -95,20 +95,20 @@
     "@finos/eslint-plugin-legend-studio": "workspace:*",
     "@finos/legend-dev-utils": "workspace:*",
     "@finos/stylelint-config-legend-studio": "workspace:*",
-    "@types/node": "18.14.2",
+    "@types/node": "18.14.6",
     "chalk": "5.2.0",
     "cross-env": "7.0.3",
     "envinfo": "7.8.1",
     "eslint": "8.35.0",
     "fs-extra": "11.1.0",
     "husky": "8.0.3",
     "inquirer": "9.1.4",
-    "jest": "29.4.3",
+    "jest": "29.5.0",
     "lint-staged": "13.1.2",
     "micromatch": "4.0.5",
     "npm-run-all": "4.1.5",
     "prettier": "2.8.4",
-    "rimraf": "4.1.2",
+    "rimraf": "4.3.1",
     "sass": "1.58.3",
     "semver": "7.3.8",
     "sort-package-json": "2.4.1",
@@ -117,7 +117,7 @@
     "typescript": "4.9.5",
     "yargs": "17.7.1"
   },
-  "packageManager": "yarn@3.4.0",
+  "packageManager": "yarn@3.4.1",
   "engines": {
     "node": ">=16.17.0",
     "yarn": ">=1.22.10"

packages/babel-preset/package.json

@@ -41,7 +41,7 @@
   "devDependencies": {
     "cross-env": "7.0.3",
     "eslint": "8.35.0",
-    "rimraf": "4.1.2",
+    "rimraf": "4.3.1",
     "typescript": "4.9.5"
   },
   "peerDependencies": {

packages/eslint-plugin/package.json

@@ -33,9 +33,9 @@
   "dependencies": {
     "@babel/core": "7.21.0",
     "@babel/eslint-parser": "7.19.1",
-    "@typescript-eslint/eslint-plugin": "5.53.0",
-    "@typescript-eslint/parser": "5.53.0",
-    "eslint-config-prettier": "8.6.0",
+    "@typescript-eslint/eslint-plugin": "5.54.1",
+    "@typescript-eslint/parser": "5.54.1",
+    "eslint-config-prettier": "8.7.0",
     "eslint-plugin-import": "2.27.5",
     "eslint-plugin-prettier": "4.2.1",
     "eslint-plugin-react": "7.32.2",
@@ -45,7 +45,7 @@
   },
   "devDependencies": {
     "cross-env": "7.0.3",
-    "rimraf": "4.1.2"
+    "rimraf": "4.3.1"
   },
   "peerDependencies": {
     "eslint": "^8.0.0",

packages/legend-application-pure-ide-deployment/package.json

@@ -46,7 +46,7 @@
     "cross-env": "7.0.3",
     "eslint": "8.35.0",
     "npm-run-all": "4.1.5",
-    "rimraf": "4.1.2",
+    "rimraf": "4.3.1",
     "typescript": "4.9.5",
     "webpack": "5.75.0",
     "webpack-bundle-analyzer": "4.8.0",

packages/legend-application-pure-ide/package.json

@@ -51,21 +51,21 @@
     "@types/react": "18.0.28",
     "@types/react-dom": "18.0.11",
     "mobx": "6.8.0",
-    "mobx-react-lite": "3.4.0",
-    "monaco-editor": "0.36.0",
+    "mobx-react-lite": "3.4.2",
+    "monaco-editor": "0.36.1",
     "react": "18.2.0",
     "react-dnd": "16.0.1",
     "react-dom": "18.2.0",
     "serializr": "3.0.2"
   },
   "devDependencies": {
     "@finos/legend-dev-utils": "workspace:*",
-    "@jest/globals": "29.4.3",
+    "@jest/globals": "29.5.0",
     "cross-env": "7.0.3",
     "eslint": "8.35.0",
-    "jest": "29.4.3",
+    "jest": "29.5.0",
     "npm-run-all": "4.1.5",
-    "rimraf": "4.1.2",
+    "rimraf": "4.3.1",
     "sass": "1.58.3",
     "typescript": "4.9.5"
   },