Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/cast-ids-to-string #28

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

fivetran-catfritz
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz commented Nov 20, 2024

PR Overview

This PR will address the following Issue/Feature:

This PR will result in the following new package version:

  • v0.8.0 because of casting changes.

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Breaking Changes

  • Casted *_id fields as strings in upstream stg_* models to ensure compatibility in downstream joins.

Documentation

  • Update dbt documentation definitions.
  • Update README formatting.

Under the Hood

  • Added an additional integration test to verify functionality when greenhouse_using_* variables are disabled.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

  • I was able to recreate the issue with the seed data in Big Query:

    • Screenshot 2024-11-20 at 4 21 11 PM
  • The updates resolve the error, however I was unable to run consistency tests due to the cast changes.

If you had to summarize this PR in an emoji, which would it be?

💃

@fivetran-catfritz fivetran-catfritz self-assigned this Nov 20, 2024
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-catfritz thanks for working on this PR! Just a few small comments and requests before approval. Let me know once it's ready for re-review!

README.md Outdated Show resolved Hide resolved
Comment on lines +2 to +7
# - package: fivetran/greenhouse_source
# version: [">=0.8.0", "<0.9.0"]

- git: https://github.com/fivetran/dbt_greenhouse_source.git
revision: bug/cast-ids-to-string
warn-unpinned: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to swap before merge

.gitignore Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
fivetran-catfritz and others added 2 commits November 21, 2024 18:44
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Copy link
Contributor Author

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-joemarkiewicz thanks--I have updated!

README.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants