Apply suggestions from code review

fivetran · Apr 3, 2024 · 53e1539 · 53e1539
1 parent 2310f41
commit 53e1539
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/models/intermediate/int_quickbooks__general_ledger_date_spine.sql b/models/intermediate/int_quickbooks__general_ledger_date_spine.sql
@@ -4,7 +4,7 @@ with spine as (
 
     {% if execute %}
     {% set first_date_query %}
-        select  coalesce(min(transaction_date),{{ dbt.dateadd("month", -1, "current_date") }}) as min_date from {{ ref('quickbooks__general_ledger') }}
+        select  coalesce(min(cast(transaction_date as date)),cast({{ dbt.dateadd("month", -1, "current_date") }} as date)) as min_date from {{ ref('quickbooks__general_ledger') }}
     {% endset %}
     {% set first_date = run_query(first_date_query).columns[0][0]|string %}
 
@@ -21,7 +21,7 @@ with spine as (
 
     {% if execute %}
     {% set last_date_query %}
-        select  coalesce(max(transaction_date), current_date) as max_date from {{ ref('quickbooks__general_ledger') }}
+        select  coalesce(max(cast(transaction_date as date)), cast(current_date as date)) as max_date from {{ ref('quickbooks__general_ledger') }}
     {% endset %}
 
     {% set current_date_query %}