Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Update spine logic for salesforce_history models #54

Open
1 of 4 tasks
fivetran-catfritz opened this issue Jun 14, 2024 · 0 comments
Open
1 of 4 tasks
Labels
type:enhancement New functionality or enhancement

Comments

@fivetran-catfritz
Copy link
Contributor

fivetran-catfritz commented Jun 14, 2024

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

In this PR, we updated the logic of the model int_salesforce__date_spine, which is used in salesforce__daily_activity. The salesforce__*_history models should also be updated to use similar coalesce logic, as well as the dbt_utils.get_single_value macro. This will help keep the logic consistent and simplify the code a bit.

The models affected are:

  • salesforce__account_daily_history
  • salesforce__contact_daily_history
  • salesforce__opportunity_daily_history

Describe alternatives you've considered

No response

Are you interested in contributing this feature?

  • Yes.
  • Yes, but I will need assistance and will schedule time during your office hours for guidance.
  • No.

Anything else?

No response

@fivetran-catfritz fivetran-catfritz added enhancement New feature or request type:enhancement New functionality or enhancement and removed enhancement New feature or request labels Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New functionality or enhancement
Projects
None yet
Development

No branches or pull requests

1 participant