Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Standard Updates #57

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

fivetran-joemarkiewicz
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz commented Aug 28, 2024

This pull request was created automatically 🎉:

  • Ensure .github/ files have been properly updated (templates are updated and auto releaser is included)
  • Confirm all appropriate end models are included in the .quickstart/quickstart.yml file as public_models (only for transform repos)
  • Verify the README has made all necessary updates:
    • Removal of emojis
    • Replacing exclamation points with periods in sentences
    • Adjusting all headers to ensure only one H1 heading
    • Confirming a section header is included for Quickstart UI rendering (only for transform repos)
    • Renaming **model to **table** (only for transform repos)
    • Removal of Fivetran community and office hour resources (if necessary)

README.md Outdated Show resolved Hide resolved
"salesforce__owner_performance",
"salesforce__sales_snapshot"
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-joemarkiewicz Do we want to include the history models here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question @fivetran-catfritz. The history models are not available in Quickstart. So we will intentionally leave them off the list.

Copy link
Contributor

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fivetran-catfritz fivetran-catfritz merged commit eeddf84 into main Sep 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants