Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Unrealised Currency Gains not reported #48

Open
2 of 4 tasks
brandonrf94 opened this issue Jun 10, 2024 · 1 comment
Open
2 of 4 tasks

[Bug] Unrealised Currency Gains not reported #48

brandonrf94 opened this issue Jun 10, 2024 · 1 comment
Labels
type:wontfix This will not be worked on

Comments

@brandonrf94
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Describe the issue

Xero reports unrealised currency gains, similar to quickbooks - but this transformation does not include the calcuation.

I noticed in the ReadMe history there was a mention about this but that mention was removed, can you confirm if unrealised gains/losses should be captured or not?

Relevant error log or model output

n.a

Expected behavior

Unrealsied gains should be available on the P&L

dbt Project configurations

Open invoices/bills should capture unrealised gains/losses in the transformation

Package versions

Using quickstart

What database are you using dbt with?

snowflake

dbt Version

Quickstart

Additional Context

No response

Are you willing to open a PR to help address this issue?

  • Yes.
  • Yes, but I will need assistance and will schedule time during our office hours for guidance
  • No.
@brandonrf94 brandonrf94 added the bug Something isn't working label Jun 10, 2024
@fivetran-avinash
Copy link
Contributor

Hi @brandonrf94, at this moment we cannot capture unrealized currency gains, as we would need to know what the currency exchange rates are for each transaction. This is not something that is available within the Xero connector ERD. Without it, we can't work backward to understand what the gains or losses are. More details are here in the "Note about currency gains" section of the README.

I see you created a support ticket within Fivetran regarding this being a Transformations issue. This is actually a connector issue, as we would need those exchange rates available within the ERD schema to bring into our data models and then provide unrealized currency gains in the final models.

I'd recommend updating your Fivetran support request for an update in the Xero connector to include exchange rates, and once that's provided, we can work on adding support for unrealized gains.

Hope that helps!

@fivetran-avinash fivetran-avinash added type:wontfix This will not be worked on and removed bug Something isn't working labels Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants