Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No confirm action alert #1431

Closed
1v4n4 opened this issue Feb 29, 2024 · 4 comments
Closed

No confirm action alert #1431

1v4n4 opened this issue Feb 29, 2024 · 4 comments

Comments

@1v4n4
Copy link
Member

1v4n4 commented Feb 29, 2024

The "Please check email and confirm action" snack is not working anymore for some cases.

Example (LC):
"consent": {
"email": {
"confirmAction": true
},
"implicit": true
},

It is because when action is taken the data.privacy is null, the code:

if (props.email?.confirmAction && data.privacy) {

@tttp
Copy link
Member

tttp commented Mar 1, 2024

mid term: implement that: #1350

short term: what is in data.privacy now? we need to change the test to it triggers if the form was filled but not if coming back from the click confirm in the email

@1v4n4
Copy link
Member Author

1v4n4 commented Mar 1, 2024

For LC, with implicit:true, data .privacy is null

@tttp
Copy link
Member

tttp commented Mar 1, 2024

so
if (props.email?.confirmAction && (data.privacy || data.privacy === null))

should work, try and then go on the page with proca_go=Share to see if it isn't triggered

@1v4n4
Copy link
Member Author

1v4n4 commented Mar 1, 2024

Short term: 21ee683

@tttp tttp closed this as completed Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants