Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update skip path to use prefix #1606

Merged
merged 1 commit into from
Nov 11, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions auth/middleware.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (
"errors"
"fmt"
"log/slog"
"slices"
"strings"
"time"

"github.com/flanksource/commons/hash"
Expand Down Expand Up @@ -111,7 +111,12 @@ func Middleware(ctx context.Context, e *echo.Echo) error {

// TODO: Use regex supported path matching
func canSkipAuth(c echo.Context) bool {
return slices.Contains(skipAuthPaths, c.Path())
for _, p := range skipAuthPaths {
if strings.HasPrefix(c.Path(), p) {
return true
}
}
return false
}

func mapIDsToRoles(ctx context.Context, session *client.Session, person models.Person) error {
Expand Down
Loading