refactor: event consumer #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@moshloop Can we merge this? |
moshloop
reviewed
Aug 31, 2023
playbook/pg_listeners.go
Outdated
| } | ||
|
|
||
| // onApprovalUpdated is called when the playbook spec approval is updated | ||
| func onApprovalUpdated(ctx *api.Context, playbookID string) error { |
There was a problem hiding this comment.
Is this the only place the approvals are managed? We can't use pg_notify as the only source as we will miss event when incident commander is down
There was a problem hiding this comment.
Right! I'll add new sync consumers but sync consumers are implemented in a later PR. I'll make the change there.
moshloop
reviewed
Aug 31, 2023
* feat: separate consumer for sync and async * fix: process sync consumers in a separate transaction * fix: skip auth to /kratos/* and return 401 if session id is not a UUID. * feat: add new sync handlers for playbook events * chore: set custom pgnotify timeout for event consumer.
|
@moshloop need to merge this as well. The sync consumer PR was merged into this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.