Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[azure-pipelines-agent] opt-out of stopping services and opt-in clearing of unzip path #119

Open
jberezanski opened this issue Nov 27, 2021 · 1 comment

Comments

@jberezanski
Copy link

In my organization, we are running several build servers, each with multiple instances of the ADO agent. The servers are set up in this manner (using PowerShell DSC):

  1. the agent binaries are downloaded and extracted to a local path on the server, say: C:\Installation\ado-agent
  2. for each agent instance defined in the configuration of the server:
  • the agent binaries are copied once from the path to a dedicated directory for that agent, say: D:\Agents\Build.3 or D:\Agents\Interactive.1
  • the agent config script is invoked to connect the agent to ADO

After an agent is set up for the first time, its upgrades are managed and performed from ADO (this has various advantages over performing them at server configuration level). Over time, however, binaries in C:\Installation\ado-agent might get updated, so that new agents created on that machine in the future will start from an up-to-date version.

We have a working implementation of the process, but now I'm looking into simplifying it (specifically, step 1) using your package. To fully support my scenario, I would like to implement two optional features, controlled via package parameters:

  1. disable stopping of the services - in my scenario, updates to the agent binaries in the source location on the local disk are not related to updating running instances of the agent, so I don't want the package to interrupt running builds, for instance;
  2. clear the unzip path before unzipping - on occasion, new versions of the agent may no longer contain some files present in an older version, and if those old files remain, the agent may run into issues (I believe this had happened to us once).

Would you accept a PR with the above changes?

@flcdrg
Copy link
Owner

flcdrg commented Nov 28, 2021

Hi Jakub, yes if these are opt-in via package parameters that sounds fine.

David

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants