From 20a2426ad6a90f7f3a5218e5fc6f3192e13d1d6f Mon Sep 17 00:00:00 2001
From: Marcel Klehr <mklehr@gmx.net>
Date: Sat, 6 Jul 2024 10:55:55 +0200
Subject: [PATCH] perf(GoogleDrive, WebDav): Don't loop through all lines when
 finding highest ID

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
---
 src/lib/adapters/GoogleDrive.ts | 5 +++--
 src/lib/adapters/WebDav.ts      | 5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/lib/adapters/GoogleDrive.ts b/src/lib/adapters/GoogleDrive.ts
index da7fedbdfc..0a1c6ce9b7 100644
--- a/src/lib/adapters/GoogleDrive.ts
+++ b/src/lib/adapters/GoogleDrive.ts
@@ -249,14 +249,15 @@ export default class GoogleDriveAdapter extends CachingAdapter {
 
       /* let's get the highestId */
       const byNL = xmlDocText.split('\n')
-      byNL.forEach(line => {
+      for (const line of byNL) {
         if (line.indexOf('<!--- highestId :') >= 0) {
           const idxStart = line.indexOf(':') + 1
           const idxEnd = line.lastIndexOf(':')
 
           this.highestId = parseInt(line.substring(idxStart, idxEnd))
+          break
         }
-      })
+      }
 
       this.bookmarksCache = XbelSerializer.deserialize(xmlDocText)
       if (this.lockingInterval) {
diff --git a/src/lib/adapters/WebDav.ts b/src/lib/adapters/WebDav.ts
index e50c197417..6872bf8015 100644
--- a/src/lib/adapters/WebDav.ts
+++ b/src/lib/adapters/WebDav.ts
@@ -224,14 +224,15 @@ export default class WebDavAdapter extends CachingAdapter {
 
       /* let's get the highestId */
       const byNL = xmlDocText.split('\n')
-      byNL.forEach(line => {
+      for (const line of byNL) {
         if (line.indexOf('<!--- highestId :') >= 0) {
           const idxStart = line.indexOf(':') + 1
           const idxEnd = line.lastIndexOf(':')
 
           this.highestId = parseInt(line.substring(idxStart, idxEnd))
+          break
         }
-      })
+      }
 
       switch (this.server.bookmark_file_type) {
         case 'xbel':