Sync interval

[kalekad]

Which version of floccus are you using?

v4.18.0

Sync method

WebDAV

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

Tor Browser 12.0.1(Firefox 102.6esr), Android

Which version of Nextcloud Bookmarks are you using? (if relevant)

No response

Which version of Nextcloud? (if relevant)

No response

What kind of WebDAV server are you using? (if relevant)

No response

Describe the Bug

I set the sync interval to 5 minutes and save. I reopen the settings and the sync interval is at 15 minutes.

Expected Behavior

A sync interval of 5 minutes remains stored.

To Reproduce

Debug log provided

• I have provided a debug log file

[marcelklehr]

It seems only 5minutes was forbidden due to a legacy rule. Fixed now.

[kalekad]

In v4.18.1 the color of the indicator changed from red to blue when selecting a 5 min interval, but it still does not save.

[marcelklehr]

Confirmed. Weird. I tested this before the release and it was working :/

[kolinger]

Last fix removed one part of condition but identical condition was left few lines bellow:

floccus/src/ui/components/OptionSyncInterval.vue

Lines 49 to 61 in 8812859

	watch: {
	value() {
	this.syncIntervalStep = this.syncIntervalSteps.reduce((closestIndex, value, index) => {
	const currentDelta = Math.abs(this.syncIntervalSteps[closestIndex] - this.value)
	const newDelta = Math.abs(value - this.value)
	if (currentDelta > newDelta) return index
	else return closestIndex
	}, 0) || this.syncIntervalSteps.indexOf(15)
	},
	syncIntervalStep(step) {
	this.$emit('input', this.syncIntervalSteps[step])
	},
	},

Where zero index is taken as invalid value and overridden by default 15 minute interval. But zero index is first option of interval and that's 5 minutes, thus 5 minutes is always overridden by 15 minutes.

This is why 5 minute interval still can't be saved with 4.19.1 as #1414 reports and thus this issues wasn't fixed yet.

[marcelklehr]

Thank you @kolinger for investigating this!

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.