Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync of private tabs #1425

Closed
1 task
Mrothyr opened this issue Nov 10, 2023 · 3 comments
Closed
1 task

Sync of private tabs #1425

Mrothyr opened this issue Nov 10, 2023 · 3 comments

Comments

@Mrothyr
Copy link

Mrothyr commented Nov 10, 2023

Which version of floccus are you using?

4.19.1

Sync method

Nextcloud Bookmarks

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

Kiwi Browser (Android)

Which version of Nextcloud Bookmarks are you using? (if relevant)

No response

Which version of Nextcloud? (if relevant)

No response

What kind of WebDAV server are you using? (if relevant)

No response

Describe the Bug

I sync the open tabs. Floccus sync the nirmal tabs AND the private tabs - and open the private tabs then in the normal view. The extension is NOT activated for private tabs.

Expected Behavior

Private tabs shouln't be synced.

To Reproduce

Open some private tabs, sync open tabs. Wait for sync.

Debug log provided

  • I have provided a debug log file
@Mrothyr Mrothyr added the bug label Nov 10, 2023
Copy link

Hello 👋

Thank you for taking the time to open this issue with floccus. I know it's frustrating when software
causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at
and if possible solved.
I'm Marcel and I created floccus and have been maintaining it ever since.
I currently work for Nextcloud which leaves me with less time for side projects like this one
than I used to have.
I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it.
Until then, please be patient.
Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation
to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can
collaborate to make this software better. For everyone.
Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge
and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and
try to fix the odd bug yourself. Everyone will be thankful for extra helping hands!
One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the forum,
to twitter or somewhere else. But this is a technical issue tracker, so please make sure to
focus on the tech and keep your opinions to yourself.

I look forward to working with you on this issue
Cheers 💙

@marcelklehr
Copy link
Member

Hello @Mrothyr

The extension is NOT activated for private tabs.

This does not affect access to tabs, only access to tab contents.

I will investigate if it is possible to find out which tabs are private.

Copy link

github-actions bot commented Dec 7, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

No branches or pull requests

2 participants