Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when syncing in a bookmark with all-numeric title #1452

Closed
1 task
gvegidy opened this issue Dec 9, 2023 · 5 comments
Closed
1 task

Error when syncing in a bookmark with all-numeric title #1452

gvegidy opened this issue Dec 9, 2023 · 5 comments
Labels

Comments

@gvegidy
Copy link

gvegidy commented Dec 9, 2023

Which version of floccus are you using?

5.0.1

Sync method

WebDAV

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

Firefox 120.0.1 on Fedora Linux x86_64

Which version of Nextcloud Bookmarks are you using? (if relevant)

No response

Which version of Nextcloud? (if relevant)

No response

What kind of WebDAV server are you using? (if relevant)

Apache httpd

Describe the Bug

When syncing in (not out) a bookmark with a all-numeric title I get an error. It looks like a type mismatch.

This is what I have in the xbel file on the server:

   <bookmark href="http://test.example.com/" id="1338">
      <title>12345</title>
    </bookmark>

This is what I get when floccus tries to sync:

Could not update - #UWaXW_MJka3O[12345](http://test.example.com/) parentId: ncsIvj_cAQeO: Type error for parameter changes (Error processing title: Expected string instead of 12345) for bookmarks.update.

This bookmark didn't create issues with floccus v4.19.1

Expected Behavior

Syncs without issue, title is kept as entered

To Reproduce

   <bookmark href="http://test.example.com/" id="1338">
      <title>12345</title>
    </bookmark>

Debug log provided

  • I have provided a debug log file
@gvegidy gvegidy added the bug label Dec 9, 2023
@marcelklehr
Copy link
Member

Confirmed and fixed.

@gvegidy
Copy link
Author

gvegidy commented Dec 9, 2023

wow, that was fast. Thank you.

@marcelklehr
Copy link
Member

heh, trying to mitigate toothing pains from the v5 launch as fast as possible...

Copy link

github-actions bot commented Dec 9, 2023

Hello 👋

Thank you for taking the time to open this issue with floccus. I know it's frustrating when software
causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at
and if possible solved.
I'm Marcel and I created floccus and have been maintaining it ever since.
I currently work for Nextcloud which leaves me with less time for side projects like this one
than I used to have.
I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it.
Until then, please be patient.
Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation
to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can
collaborate to make this software better. For everyone.
Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge
and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and
try to fix the odd bug yourself. Everyone will be thankful for extra helping hands!
One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the forum,
to twitter or somewhere else. But this is a technical issue tracker, so please make sure to
focus on the tech and keep your opinions to yourself.

I look forward to working with you on this issue
Cheers 💙

@marcelklehr marcelklehr moved this to Done in Floccus May 19, 2024
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants