Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decryption stopped working, unable to sync #1457

Closed
1 task
Seirade opened this issue Dec 10, 2023 · 10 comments
Closed
1 task

Decryption stopped working, unable to sync #1457

Seirade opened this issue Dec 10, 2023 · 10 comments
Labels

Comments

@Seirade
Copy link

Seirade commented Dec 10, 2023

Which version of floccus are you using?

5.0.2

Sync method

WebDAV

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

Firefox 115.5.0esr (64-bit)

Which version of Nextcloud Bookmarks are you using? (if relevant)

No response

Which version of Nextcloud? (if relevant)

No response

What kind of WebDAV server are you using? (if relevant)

LoFloccus v1.2.3 (https://github.com/TCB13/LoFloccus)

Describe the Bug

After the recent update, I noticed Floccus hasn't been syncing for the past 2 days. Error is:

E030: Failed to decrypt bookmarks file. The passphrase may be wrong or the file may be corrupted.

Floccus also keeps trying to sync, despite the Auto-sync option being disabled. I tried retyping the Password in the Server Details, Pulling down once, and restarting the browser, but it's unable to decrypt. On a different machine, same browser version, Floccus v4.19.1 still works, so it must have been the v5.0 update that broke.

Expected Behavior

Floccus should be able to decrypt the bookmarks file in order to write to it properly.

To Reproduce

On Firefox 115.5.0esr (64-bit), upgrade from Floccus v4.19.1 to v5.0.2. Decryption should suddenly not work.

Debug log provided

  • I have provided a debug log file
@Seirade Seirade added the bug label Dec 10, 2023
Copy link

Hello 👋

Thank you for taking the time to open this issue with floccus. I know it's frustrating when software
causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at
and if possible solved.
I'm Marcel and I created floccus and have been maintaining it ever since.
I currently work for Nextcloud which leaves me with less time for side projects like this one
than I used to have.
I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it.
Until then, please be patient.
Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation
to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can
collaborate to make this software better. For everyone.
Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge
and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and
try to fix the odd bug yourself. Everyone will be thankful for extra helping hands!
One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the forum,
to twitter or somewhere else. But this is a technical issue tracker, so please make sure to
focus on the tech and keep your opinions to yourself.

I look forward to working with you on this issue
Cheers 💙

@marcelklehr
Copy link
Member

Hello @Seirade

Can you check the file in question to see if it's actually encrypted? In v4.x there was a bug that would prevent the file from actually getting encrypted, so floccus might be trying to decrypt a plain text flie now

@Seirade
Copy link
Author

Seirade commented Dec 10, 2023

The file is still encrypted. I never had any issues with it in v4.x. I also have two other browsers that don't auto-update extensions, and Floccus still works fine there. One is on v4.17.1 and the other's on v4.19.1. I'm hesitant on updating those until it's working properly again.

@tom709
Copy link

tom709 commented Dec 11, 2023

Same problem here. I am running Floccus against a Webdav backed by NGinx with an encrypted xbel file. After upgrade to 5.0.2 the sync does not work any more. The xbel file is not updated and even the Floccus log is still from the last time I synced with Floccus 4.19.1. I tried downgrading to 4.19.1 but even with the old version, now the sync does not work any more.

@Seirade
Copy link
Author

Seirade commented Dec 11, 2023

I didn't try downgrading, but I did just now and can also confirm that it did not fix it. Another weird observation that I forgot to mention earlier was that it doesn't ask you for credentials when starting up the browser. They seemed to not be set so I tried setting them up again with "Secure your credentials", but no luck.

@marcelklehr
Copy link
Member

Ahh, you've been using the "secure your credentials" feature? That was removed in v5. I suppose the code responsible for migrating has a bug. Short term workaround is to setup the profile from scratch.

@Seirade
Copy link
Author

Seirade commented Dec 11, 2023

I tried exporting the account (profile) from v4.19.1 to make setting it up easier. I even removed the credentials before exporting, but got an error in v5.0.2 when importing it:

permissions.request may only be called from a user input handler

Setting it up completely from scratch did work, however. Everything seems to work, including syncs between different versions.

@Eyion
Copy link

Eyion commented Dec 12, 2023

Which version of floccus are you using?
5.0.2

Sync method
WebDAV

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.
Android App

Describe the Bug
When I use the sync feature, I get error E017(Network error: Please check your network connection or account information), which ends up not completing the sync successfully.This problem did not occur when using version 4.19.1.

@tom709
Copy link

tom709 commented Dec 12, 2023

In my case the sync failed after upgrading from 4.19.1 to 5.0.2 even though the "secure your credentials" feature is not activated. The symptom was that the sync did not seem to finish. The spinning "syncing arrows" were interrupted by an "All good" for a fraction of a second, but then, the "syncing" continued and this never ended. My sync interval is set to 15 minutes. I only posted here because I found that my XBEL file on the Webdav server does contain readable XML, so I thought it is encrypted. After downgrading to 4.19.1, at first the sync seemed to take forever again, but then, after an hours or so I noticed that it had actually succeeded. Very strange that.
Edit: after reading the section about lock files in the FAQ I tried again to sync on 5.0.2 and now that works too. So perhaps it was just a stale lock file in my case.
Edit2: ...but it happened again. With 5.0.2 I am now again in a state where Floccus syncs continuously, just briefly interrupted by a split second "all good" every now and then. I increased the sync interval from 15 to 20 min and saved that, but no change.

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Status: Done
Development

No branches or pull requests

4 participants