QuiclAccessToolbar not save items.

[mpventum]

Hi, guys
I want to develop an extension of the Fluent.Ribbon QuickAccessToolbar to save the QuickAccessItems when applicaiton was closed.
There is an entry point to perform this?

Thanks so much

[batzen]

Hi there,

you can solve this by grabbing a reference to myRibbon.QuickAccessToolBar and add items on load and save the items when the containing windows is closed, or remember the items as soon as ItemsChanged on QuickAccessToolBar is raised.
If you want to extend the ribbons built-in state storage, you can inherit from Ribbon and override CreateRibbonStateStorage to return your own class which has to implement IRibbonStateStorage or derive from RibbonStateStorage if you decide to derive from RibbonStateStorage please consider writing tests for your derived class as the format used to store the settings might change in any version.

The commit which removed the storage of QAT items is 383f17f and the reasons for it's removal are documented in #810. The removed code shows how you could save the items, but you shouldn't use the exact same code because of the reasons listed in #810.
If you find a stable solution to save your items it would be very nice if you could share your solution as no one else has come up with a solution so far.

[mpventum]

Thans so much.
i save the QuickAccessToolBar.Items on Window_Closing and load the same on Window_Loaded or separated event as below:
` private void loadQuickAccessToolBar()

    {

        if (File.Exists(PATH_FILE_CONF)){
            myRibbon.QuickAccessToolBar.Items.Clear();
            string[] reads = File.ReadAllLines(PATH_FILE_CONF);
            foreach (var item in reads)
            {
                var elem = myRibbon.FindName(item) as FrameworkElement;
                myRibbon.QuickAccessToolBar.Items.Add(elem);
            }
        }
    }`

but on exit of method i have an exception at this row: QuickAccessToolBar.cs -> MeasureOverride -> row: 463- >
for (var i = 0; i < this.cachedNonOverflowItemsCount; i++)

the exception is:
System.InvalidOperationException
HResult=0x80131509
Message=L'elemento specificato è già il figlio logico di un altro elemento. È innanzitutto necessario disconnetterlo.
Source=PresentationFramework
StackTrace:
at System.Windows.FrameworkElement.ChangeLogicalParent(DependencyObject newParent)
at System.Windows.FrameworkElement.AddLogicalChild(Object child)
at System.Windows.Controls.UIElementCollection.AddInternal(UIElement element)
at System.Windows.Controls.UIElementCollection.Add(UIElement element)
at Fluent.QuickAccessToolBar.MeasureOverride(Size constraint) in C:\projects\fluent-ribbon\Fluent.Ribbon\Controls\QuickAccessToolBar.cs:line 465
at System.Windows.FrameworkElement.MeasureCore(Size availableSize)
at System.Windows.UIElement.Measure(Size availableSize)
at System.Windows.ContextLayoutManager.UpdateLayout()
at System.Windows.ContextLayoutManager.UpdateLayoutCallback(Object arg)
at System.Windows.Media.MediaContext.InvokeOnRenderCallback.DoWork()
at System.Windows.Media.MediaContext.FireInvokeOnRenderCallbacks()
at System.Windows.Media.MediaContext.RenderMessageHandlerCore(Object resizedCompositionTarget)
at System.Windows.Media.MediaContext.RenderMessageHandler(Object resizedCompositionTarget)
at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
at System.Windows.Threading.DispatcherOperation.InvokeImpl()
at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(Object state)
at MS.Internal.CulturePreservingExecutionContext.CallbackWrapper(Object obj)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
at MS.Internal.CulturePreservingExecutionContext.Run(CulturePreservingExecutionContext executionContext, ContextCallback callback, Object state)
at System.Windows.Threading.DispatcherOperation.Invoke()
at System.Windows.Threading.Dispatcher.ProcessQueue()
at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Int32 numArgs)
at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
at System.Windows.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
at System.Windows.Application.RunDispatcher(Object ignore)
at System.Windows.Application.RunInternal(Window window)
at System.Windows.Application.Run(Window window)
at System.Windows.Application.Run()
at ProvaRibbonSource.App.Main()

This exception was originally thrown at this call stack:
System.Windows.FrameworkElement.ChangeLogicalParent(System.Windows.DependencyObject)
System.Windows.FrameworkElement.AddLogicalChild(object)
System.Windows.Controls.UIElementCollection.AddInternal(System.Windows.UIElement)
System.Windows.Controls.UIElementCollection.Add(System.Windows.UIElement)
Fluent.QuickAccessToolBar.MeasureOverride(System.Windows.Size) in QuickAccessToolBar.cs
System.Windows.FrameworkElement.MeasureCore(System.Windows.Size)
System.Windows.UIElement.Measure(System.Windows.Size)
System.Windows.ContextLayoutManager.UpdateLayout()
System.Windows.ContextLayoutManager.UpdateLayoutCallback(object)
System.Windows.Media.MediaContext.InvokeOnRenderCallback.DoWork()
...
[Call Stack Truncated]

[batzen]

That's strange as only accessing the QAT items should not cause any rendering.
Could you show the code that's called when saving the items?

[mpventum]

Thanks
this is the code:

//I save the x:name of the button for identify
   private void saveQuickAccessToolBar()
        {
            StreamWriter file = new StreamWriter(PATH_FILE_CONF);
            foreach (var item in myRibbon.QuickAccessToolBar.Items)
            {
                if (item is DependencyObject)
                {
                    file.WriteLine(GetElementName(item));
                }
            }

            file.Close();
        }

//get element name for saving on config fie
  private string GetElementName(DependencyObject element)
        {
            LocalValueEnumerator locallySetProperties = element.GetLocalValueEnumerator();
            string retName = string.Empty;
            if (locallySetProperties.MoveNext())
            {
                if (locallySetProperties.Current.Value is BindingExpression)
                {
                    if ((locallySetProperties.Current.Value as BindingExpression).DataItem is FrameworkElement)
                    {
                        retName = "" + ((locallySetProperties.Current.Value as BindingExpression).DataItem as FrameworkElement).Name;
                    }
                }
            }
            return retName;
        }

[batzen]

Ah, now I get what's wrong.
It's not the saving but the loading instead.
You are grabbing a FrameworkElement from the Ribbon via FindName and add it to the QAT.
That's not possible in WPF as the element is already part of the Ribbon, and thus part of the visual/logical tree.
You should use myRibbon.AddToQuickAccessToolBar(elem) instead, as that method correctly creates a separate control instance which is then automatically added to the QAT.

[mpventum]

ohhhh yeahhh it's works fine.
In this way I manage the persistence of QTA.
I developed the method GetElementName because the element of QTA does not have the name (or other identify) of FrameworkElement.

Thanks so much Bastian