Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: implement strategy of overwrite order tree in circuit #105

Open
0xmountaintop opened this issue Mar 13, 2021 · 5 comments
Open

feature: implement strategy of overwrite order tree in circuit #105

0xmountaintop opened this issue Mar 13, 2021 · 5 comments
Assignees
@0xmountaintop

Comments

@0xmountaintop
Copy link
Member

No description provided.

@0xmountaintop 0xmountaintop self-assigned this Mar 13, 2021
@0xmountaintop
Copy link
Member Author

closed via #110

@0xmountaintop 0xmountaintop reopened this Mar 17, 2021
@lispc lispc mentioned this issue May 5, 2021
Merged
@0xmountaintop
Copy link
Member Author

In previous version we check signature for PlaceOrder.

Now we don't have PlaceOrder anymore and we don't check signature for SpotTrade?

In my opinion we should still verify "place_order" tx signature in SpotTrade.

@lispc
Copy link
Member

lispc commented Jun 19, 2021

Sigs are verified. https://github.com/Fluidex/circuits/blob/57c7fdcb373c3f7b9e286ed452400a007f7aa2e9/src/spot_trade.circom#L317

@lispc
Copy link
Member

lispc commented Jun 19, 2021

https://github.com/Fluidex/circuits/blob/57c7fdcb373c3f7b9e286ed452400a007f7aa2e9/src/block.circom#L141

@0xmountaintop
Copy link
Member Author

I see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xmountaintop 0xmountaintop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lispc @0xmountaintop