Migrate flutter/engine to a Dart workspace for Dart/pub packages
#147883
Assignees
Labels
c: tech-debt
Technical debt, code quality, testing, etc.
engine
flutter/engine repository. See also e: labels.
P2
Important issues not at the top of the work list
team-engine
Owned by Engine team
triaged-engine
Triaged by Engine team
Comments
matanlurey
added
engine
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this issue
Jul 18, 2024
... and use it in `engine_tool` to prove everything is working, i.e. on CI and elsewhere. Partial work towards flutter/flutter#147883. Supersedes and closes #51782 (which was a prototype). See also: - https://flutter.dev/go/pub-workspace, the design doc on the feature. - dart-lang/pub-dev#7762, an example PR. I'll probably end up moving the inline docs in `pubspec.yaml` to a `docs/*.md` once that's a thing.
itsjustkevin
pushed a commit
to itsjustkevin/engine
that referenced
this issue
Jul 19, 2024
…3539) ... and use it in `engine_tool` to prove everything is working, i.e. on CI and elsewhere. Partial work towards flutter/flutter#147883. Supersedes and closes flutter#51782 (which was a prototype). See also: - https://flutter.dev/go/pub-workspace, the design doc on the feature. - dart-lang/pub-dev#7762, an example PR. I'll probably end up moving the inline docs in `pubspec.yaml` to a `docs/*.md` once that's a thing.
matanlurey
added a commit
to flutter/engine
that referenced
this issue
Jul 27, 2024
Part of flutter/flutter#147883. Excluding Fuchsia and the Web SDK, the remaining scripts are: ```sh $ ./tools/find_pubspecs_to_workspacify.sh /Users/matanl/Developer/engine/src/flutter/impeller/tessellator/dart/pubspec.yaml /Users/matanl/Developer/engine/src/flutter/sky/packages/sky_engine/pubspec.yaml /Users/matanl/Developer/engine/src/flutter/shell/vmservice/pubspec.yaml /Users/matanl/Developer/engine/src/flutter/lib/snapshot/pubspec.yaml /Users/matanl/Developer/engine/src/flutter/lib/gpu/pubspec.yaml /Users/matanl/Developer/engine/src/flutter/lib/web_ui/pubspec.yaml /Users/matanl/Developer/engine/src/flutter/flutter_frontend_server/pubspec.yaml ``` These could be the trickiest, so I'm doing them separately.
matanlurey
added a commit
to flutter/engine
that referenced
this issue
Jul 31, 2024
|
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
tl;dr: Dart tooling is landing support for so-called Pub workspaces, the engine should use them when ready.
Right now,
flutter/enginehas many, manypubspec.yamlfile each of which needs to be independently maintained, and comply with our policy of not resolving any packages to external data sources (i.e., all packages have to either be vended by the Dart SDK, or via our ownDEPSfile).The impact of this is perhaps most profound when you look at the necessary dependencies needed to use
package:testas a dependency, which at the time of this writing, was nearly ~50 packages (and hand-written paths that resolve to different directories depending on the package).With upcoming pub workspaces, we could instead:
flutter/engine/pubspec.yamllisting all pub dependencies we use.resolution: workspaceUnblocks #133569.
See also:
The text was updated successfully, but these errors were encountered: