From 18f1e8e2d4b367b2bf24269110793ed1b33c770a Mon Sep 17 00:00:00 2001 From: Justin McCandless Date: Sat, 1 Jul 2023 14:32:41 -0700 Subject: [PATCH] Remove rotation from Transformation demo description since it's not implemented (#968) ## Description The transformation demo does not include rotation, but the description and subtitle says it does. This PR removes mention of rotation. Rotation is not currently supported by InteractiveViewer under the hood, though someday I'd like it to! @guidezpl What's the process for updating an existing string like this? I couldn't figure it out by reading the [l10n readme](https://github.com/flutter/gallery/tree/main/lib/l10n#readme). ## Tests None. ## Issues Fixes https://github.com/flutter/gallery/issues/967 --------- Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> --- lib/l10n/README.md | 5 +++++ lib/l10n/intl_en.arb | 4 ++-- lib/l10n/intl_en_US.xml | 4 ++-- 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/lib/l10n/README.md b/lib/l10n/README.md index 94a96835fe..35fd1eb17f 100644 --- a/lib/l10n/README.md +++ b/lib/l10n/README.md @@ -56,3 +56,8 @@ console to generate messages in the different locales. > unless necessary. See `/third_party/dart/flutter_gallery/README.md` for how to import this file and export translations. + +## Updating Existing Locale Messages + +Modify the message in `intl_en.arb`, then run `flutter pub run grinder l10n`. +This will update `intl_en_US.xml` for the translation console. diff --git a/lib/l10n/intl_en.arb b/lib/l10n/intl_en.arb index a276ad57d7..ce8f755e9c 100644 --- a/lib/l10n/intl_en.arb +++ b/lib/l10n/intl_en.arb @@ -1787,11 +1787,11 @@ "@demo2dTransformationsTitle": { "description": "Title for the 2D transformations demo." }, - "demo2dTransformationsSubtitle": "Pan, zoom, rotate", + "demo2dTransformationsSubtitle": "Pan and zoom", "@demo2dTransformationsSubtitle": { "description": "Subtitle for the 2D transformations demo." }, - "demo2dTransformationsDescription": "Tap to edit tiles, and use gestures to move around the scene. Drag to pan, pinch to zoom, rotate with two fingers. Press the reset button to return to the starting orientation.", + "demo2dTransformationsDescription": "Tap to edit tiles, and use gestures to move around the scene. Drag to pan and pinch with two fingers to zoom. Press the reset button to return to the starting orientation.", "@demo2dTransformationsDescription": { "description": "Description for the 2D transformations demo." }, diff --git a/lib/l10n/intl_en_US.xml b/lib/l10n/intl_en_US.xml index 68979fef00..ba5d946986 100644 --- a/lib/l10n/intl_en_US.xml +++ b/lib/l10n/intl_en_US.xml @@ -1680,11 +1680,11 @@ Pan, zoom, rotate + >Pan and zoom Tap to edit tiles, and use gestures to move around the scene. Drag to pan, pinch to zoom, rotate with two fingers. Press the reset button to return to the starting orientation. + >Tap to edit tiles, and use gestures to move around the scene. Drag to pan and pinch with two fingers to zoom. Press the reset button to return to the starting orientation.