[pigeon] adds event channel support for kotlin and swift #7892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarrinneal
force-pushed
the
event-channels
branch
from
462a314
to
959374c
Compare
stuartmorgan
requested changes
Nov 4, 2024
...eon/platform_tests/test_plugin/android/src/main/kotlin/com/example/test_plugin/TestPlugin.kt
Outdated
Show resolved
Hide resolved
hellohuanlin
reviewed
Nov 6, 2024
| } | ||
|
|
||
| /// Generated class from Pigeon that represents data sent in messages. | ||
| /// This class should not be extended by any user class outside of the generated file. |
There was a problem hiding this comment.
nit: protocol, not a class
stuartmorgan
requested changes
Nov 18, 2024
packages/pigeon/example/app/ios/Runner/EventChannelMessages.g.swift
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Event channels work towards flutter/flutter#66711
sealed classes with extensions (empty base classes only)
fixes flutter/flutter#155859
adds some convenience methods to Root
change generation tool to have generator exclusions per pigeon