Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvs: do not allow appends that exceed maximum allowed value size #6264

Open
chu11 opened this issue Sep 6, 2024 · 0 comments
Open

kvs: do not allow appends that exceed maximum allowed value size #6264

chu11 opened this issue Sep 6, 2024 · 0 comments

Comments

@chu11
Copy link
Member

chu11 commented Sep 6, 2024

Per discussion in #6256

I wonder if it would be easier to implement a limit on storing a large value in the first place?

I hate to suggest modifying RFC 11 but we could maybe consider adding an optional size to val and valref?
(optional in the sense that it is allowed to be missing from older metadata)

If we have a running total size for a kvs value, then we have the means to reject an append that would cause it to exceed some maximum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant