Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flux-job attach: limit size of each stdin entry to max size #6290

Open
chu11 opened this issue Sep 19, 2024 · 0 comments
Open

flux-job attach: limit size of each stdin entry to max size #6290

chu11 opened this issue Sep 19, 2024 · 0 comments

Comments

@chu11
Copy link
Member

chu11 commented Sep 19, 2024

Per discussion in #4572

Problem: we do not want to overflow the size of the stdin buffer, but its possible a single stdin entry could be larger than the stdin buffer size.

to make things easier, limit each stdin entry to be a max of the stdin buffer size. some simple math around flux job attach's attach_send_shell() should do the trick (did not analyze beyond this cursory analysis).

side note: libsubprocess needs to expose the default stdin buffersize when tools don't allow config of buffer size.

side note: other places to do this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant