From cdfd4393e64c3f8b7dd2a9bb7903270b3cbeb067 Mon Sep 17 00:00:00 2001
From: Stefan Prodan <stefan.prodan@gmail.com>
Date: Wed, 10 Apr 2024 18:07:20 +0300
Subject: [PATCH] Add note on production promotions

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
---
 README.md                                                | 9 +++++++++
 .../infra-controllers/ingress-nginx-values.yaml          | 8 --------
 clusters/production/infra-controllers/kustomization.yaml | 5 -----
 3 files changed, 9 insertions(+), 13 deletions(-)
 delete mode 100644 clusters/production/infra-controllers/ingress-nginx-values.yaml

diff --git a/README.md b/README.md
index de40767..3cbc7fa 100644
--- a/README.md
+++ b/README.md
@@ -145,6 +145,9 @@ kind: HelmRelease
 metadata:
   name: ingress-nginx
 spec:
+  chart:
+    spec:
+      version: ">=4.10.0"
   values:
     controller:
       replicaCount: 2
@@ -187,6 +190,12 @@ NAME                       READY   UP-TO-DATE
 ingress-nginx-controller   2/2     2
 ```
 
+> [!IMPORTANT]
+> Note that on production clusters, it is recommended to pin the Helm chart to an exact
+> version and to use a promotion workflow to test new versions on the staging cluster before
+> deploying to production. For more information, see the guide
+> [Promote Flux Helm Releases with GitHub Actions](https://fluxcd.io/flux/use-cases/gh-actions-helm-promotion/).
+
 ## Testing
 
 After making changes to the manifests, you can validate them locally with [kubeconform](https://github.com/yannh/kubeconform) by running:
diff --git a/clusters/production/infra-controllers/ingress-nginx-values.yaml b/clusters/production/infra-controllers/ingress-nginx-values.yaml
deleted file mode 100644
index 5ae692f..0000000
--- a/clusters/production/infra-controllers/ingress-nginx-values.yaml
+++ /dev/null
@@ -1,8 +0,0 @@
-apiVersion: helm.toolkit.fluxcd.io/v2beta2
-kind: HelmRelease
-metadata:
-  name: ingress-nginx
-spec:
-  values:
-    controller:
-      replicaCount: 2
diff --git a/clusters/production/infra-controllers/kustomization.yaml b/clusters/production/infra-controllers/kustomization.yaml
index ad77482..cb95b5d 100644
--- a/clusters/production/infra-controllers/kustomization.yaml
+++ b/clusters/production/infra-controllers/kustomization.yaml
@@ -2,8 +2,3 @@ apiVersion: kustomize.config.k8s.io/v1beta1
 kind: Kustomization
 resources:
   - ../../../deploy/infra-controllers
-patches:
-  - target:
-      kind: HelmRelease
-      name: ingress-nginx
-    path: ingress-nginx-values.yaml