Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static Alerts and Providers #626

Closed
4 tasks done
darkowlzz opened this issue Oct 5, 2023 · 0 comments
Closed
4 tasks done

Static Alerts and Providers #626

darkowlzz opened this issue Oct 5, 2023 · 0 comments
Labels
area/alerting Alerting related issues and PRs area/api API related issues and pull requests enhancement New feature or request

Comments

@darkowlzz
Copy link
Contributor

darkowlzz commented Oct 5, 2023

Like all the other Flux API objects, Alerts and Providers are backed by reconcilers and report readiness status. But unlike other objects, these reconcilers don't perform any effective action or produce any artifact. They only perform input validation, most of which can be performed using the Kubernetes API validation. Alerts and Providers are essentially data objects, similar to a ConfigMap. The configurations in Alerts and Providers are used by the event handler while processing the events received by notification-controller. For simplicity and ease of maintenance, Alerts and Providers can be made static objects that are not backed by reconcilers and don't report any status. Their existence means that they are ready. There's nothing to check if they are ready to use.

Because this change drops the whole status from Alerts and Providers, it requires a new API version, v1beta3. For migrating the old Alerts and Providers to this new API, temporary migration reconcilers will be needed for each of them, which can be removed in a future release. The loss of readiness and suspend metrics from the reconcilers have been addresses in the recent version of Flux with new monitoring setup that uses kube-state-metrics for collecting those metrics from the objects.

TODOs:

@darkowlzz darkowlzz added enhancement New feature or request area/alerting Alerting related issues and PRs area/api API related issues and pull requests labels Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alerting Alerting related issues and PRs area/api API related issues and pull requests enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants