Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core feature] Surface pod template mis-configuration in the UI. #6124

Open
2 tasks done
thomasjpfan opened this issue Dec 26, 2024 · 2 comments
Open
2 tasks done

[Core feature] Surface pod template mis-configuration in the UI. #6124

thomasjpfan opened this issue Dec 26, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@thomasjpfan
Copy link
Member

Motivation: Why do you think this is important?

When working with PodTemplates any misconfiguration do not show up in the UI. The UI only shows "pending". The only way to debug it is to see the propeller logs.

Goal: What should the final outcome look like, ideally?

The errors related to pod template misconfiguration are show in the UI.

Describe alternatives you've considered

We can also do the same type of validation on the client side so we error early.

Propose: Link/Inline OR Additional context

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@thomasjpfan thomasjpfan added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Dec 26, 2024
@eapolinario eapolinario added help wanted Extra attention is needed and removed untriaged This issues has not yet been looked at by the Maintainers labels Dec 26, 2024
@eapolinario
Copy link
Contributor

Let's investigate two (complementary) approaches:

  1. validate podspec at registration time in flytekit
  2. Use https://pkg.go.dev/k8s.io/kubernetes/pkg/apis/core/validation to validate podspecs in flyteadmin

@davidmirror-ops davidmirror-ops moved this from Backlog to Assigned in Flyte Issues/PRs maintenance Jan 2, 2025
@kevinliao852
Copy link

#take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Status: Assigned
Development

No branches or pull requests

3 participants