Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] [flytekit] Polish - Resources #6142

Open
2 tasks done
wild-endeavor opened this issue Jan 5, 2025 · 0 comments
Open
2 tasks done

[Draft] [flytekit] Polish - Resources #6142

wild-endeavor opened this issue Jan 5, 2025 · 0 comments
Labels
backlogged For internal use. Reserved for contributor team workflow. untriaged This issues has not yet been looked at by the Maintainers

Comments

@wild-endeavor
Copy link
Contributor

wild-endeavor commented Jan 5, 2025

Resources

This is a series of tickets to improve the flytekit authoring experience. If any changes are not possible to make in a backwards-compatible way, split it out into a separate ticket.

Rename argument

The argument ephemeral_storage should be renamed to disk. disk is succinct and gets the point across. Make it super clear if not already in user facing notes that the disk is ephemeral.

SHM

Should we add shm as an option to Resources? (i think the same issue that kept us from putting accelerator - the fact that resources are specified as both requests and limits - may be relevant here. Even if k8s doesn't allow it today, does it make sense to for an shm to have two different numbers here? Discuss more and probably cut a separate ticket for this (cc @granthamtaylor)

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@wild-endeavor wild-endeavor added documentation Improvements or additions to documentation untriaged This issues has not yet been looked at by the Maintainers labels Jan 5, 2025
@wild-endeavor wild-endeavor added backlogged For internal use. Reserved for contributor team workflow. and removed documentation Improvements or additions to documentation labels Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlogged For internal use. Reserved for contributor team workflow. untriaged This issues has not yet been looked at by the Maintainers
Projects
Status: Backlog
Development

No branches or pull requests

1 participant