Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid endless loop in get_git_root #196

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Avoid endless loop in get_git_root #196

merged 1 commit into from
Nov 14, 2024

Conversation

imagejan
Copy link
Member

Also, Path(__file__) leads to incorrect behavior when the environment (and therefore the imported faim_ipa package) is outside the project repository.

This can happen when using pixi config with detached-environments=true.

So, let's use the current working directory instead.

Also, Path(__file__) leads to incorrect behavior when the environment
(and therefore the imported faim_ipa package) is outside the project
repository.

This can happen when using pixi config with detached-environments=true.

So, let's use the current working directory instead.
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.75%. Comparing base (02a43e9) to head (3edb054).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
- Coverage   92.80%   92.75%   -0.05%     
==========================================
  Files          64       64              
  Lines        3918     3920       +2     
  Branches      245      246       +1     
==========================================
  Hits         3636     3636              
- Misses        268      269       +1     
- Partials       14       15       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imagejan imagejan merged commit 1870eee into main Nov 14, 2024
12 checks passed
@imagejan imagejan deleted the git-root-fixes branch November 14, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant