Improve UIntHistogram
#54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Number of bins should be len(frequencies), so let's reflect this in the calculations. Test are adapted to reflect accurate reporting of the number of bins (n_bins).
Codecov Report
@@ Coverage Diff @@
## main #54 +/- ##
==========================================
+ Coverage 93.10% 93.73% +0.62%
==========================================
Files 15 15
Lines 1291 1309 +18
==========================================
+ Hits 1202 1227 +25
+ Misses 89 82 -7
|
Include a test for loading .npz files written with `bins` included, which we now ignore.
tibuch
approved these changes
Oct 13, 2023
|
Thank you! Makes the code more readable 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Number of bins should be
len(frequencies), so let's reflect this in the calculations. Test are adapted to reflect accurate reporting of the number of bins (n_bins()).Closes #53.
We might want to add a test for loading legacy
.npzfiles that were saved with a previous version.