Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node 12.18.3 error #53

Open
vincentwan100 opened this issue Aug 21, 2020 · 3 comments
Open

node 12.18.3 error #53

vincentwan100 opened this issue Aug 21, 2020 · 3 comments

Comments

@vincentwan100
Copy link

vincentwan100 commented Aug 21, 2020

nodejs: 12
electron: 8.8.0

npm rebuild error:
BooleanValue can never throw. Use Isolate version.
[-Wdeprecated-declarations]
return value.ToLocalChecked()->BooleanValue(Nan::GetCurrentContext

@manu-st
Copy link

manu-st commented Nov 7, 2020

See PR #46 for the solution.

@AlexandreKilian
Copy link

@manu-st sorry, what was the solution? THE PR you referred to was never merged, how did you fix it for you?

@manu-st
Copy link

manu-st commented Feb 9, 2021

@AlexandreKilian I fixed it by having my package.json file points to the git repository for the associated PR:

"font-manager": "https://github.com/q-lukasz/font-manager.git#issue-45--compile-error-mac-os-x--node-13-7",

until it is fixed upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants