Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve flow of group order when a ordergroup has less than minimum balance #1032

Open
yksflip opened this issue Oct 16, 2023 · 3 comments
Open

Comments

@yksflip
Copy link
Member

yksflip commented Oct 16, 2023

It's pretty confusing for users to complete a group order when their balance is less than the configured minimum balance. Currently all sum table fields turn red and the save button is disabled. It's not understandable what's going on and that you cannot save your order anymore.

I'd suggest:

  • If your ordergroup has insufficient funds before starting the order, you are not able to edit a grouporder at all, you'll get a warning and get redirected to your grouporder profile where you can see your balance.
  • If you have enough funds to start a order and order more than your balance, you can still click the save button, but a error modal opens with a explanatory message and you can adapt your order again.
    • Another idea would be to save a "draft"-order that are incomplete orders. But I think this would be a much bigger change and open new design questions ...

related: #280

@twothreenine
Copy link
Contributor

  • If your ordergroup has insufficient funds before starting the order, you are not able to edit a grouporder at all, you'll get a warning and get redirected to your grouporder profile where you can see your balance.

I think you should still be able to view the order and which articles are offered before you decide whether you want to fill up your balance (or by how much). But we could use a warning popup/modal which can be dismissed and/or disable all + buttons of articles with a positive gross price.

  • If you have enough funds to start a order and order more than your balance, you can still click the save button, but a error modal opens with a explanatory message and you can adapt your order again.

A simple text "insufficient balance" next to the "save" button as soon as you go under the minimum would solve it pretty well, I guess?

also related to #1040

@yksflip
Copy link
Member Author

yksflip commented Feb 6, 2024

Yes I understand It would be helpful to actually see what's ordered.
I don't like the idea of disabling parts of the form very much, but would be ok if we don't find another solution.
I think I'd rather like to present the show view of the grouporder (with a notice) instead of the edit if there's not enough funds?

@twothreenine
Copy link
Contributor

Yes I understand It would be helpful to actually see what's ordered.

That too, but I meant what's offered.

I think I'd rather like to present the show view of the grouporder (with a notice) instead of the edit if there's not enough funds?

Hmm, so that an empty grouporder would be created and then shown? In the show view of the grouporder articles you haven't ordered are hidden by default, so you would need to find the Show/hide articles not ordered button and even then, you couldn't see origin and producer information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants