-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SRDB import cleanup #178
Comments
About
Below is a table of all combinations of Ecosytem_stage and Manipulation that exist in SRDB (forest and savanna).
|
note about
Stand.age is coming from Age_disturbance and if that is missing we take Age_ecosystem. Maybe Age_disturbance is not relevant when it is a minor disturbance? That might be why there are so many young plots that are labeled as mature ? |
Hmm, could be. In SRDB
There's some fuzziness around the edges, but in general the Natural-Unmanaged-Managed binning is useful I think: "no human influence", "no recent/active human management", "actively managed". |
I think that in many cases, treatments that we count as management may have been applied to natural/ unmanaged stands. That is, the designations in SRDB apply prior to application of experimental treatments. Is this correct, @bpbond ? |
Right! |
@ValentineHerr, this means that we should drop the managed/unmanaged/natural for all stands with treatments and the mature/aggrading designation when the disturbance is stand-clearing. |
I I am not sure I understand this.... Here is the current plot.name definition (coming from this issue) (note: [stage] is Aggrading, Mature, Natural or NA)
I think I translate this to:
---> then keep [stage] from the plot.name definition.
--> then drop [stage] from the plot.name definition. Is that correct?? |
Not quite. There are two separate changes. 1:
--> then drop [Ecosystem_state] from the plot.name definition. |
2: If a record (has any Manipulation corresponding to "stand-clearing" in the manipulations.csv and [stage = mature] )OR if (age<100 years and [stage = mature] ), ---> then drop [stage] from the plot.name definition. |
Is this still valid ?
|
These records have been fixed in SRDB. |
@teixeirak , about
see this issue |
I believe this is fixed but @teixeirak can double check (might need to double check in ForC_simplified once I push everything) |
I actually see a few cases of plots with treatments where "unmanaged" or "natural" remains in the plot name. For example:
I don't think these are hugely problematic or confusing, so if its a pain to fix we can leave it. |
for the first example (SRDB record 1634), it is because it says "unmanaged" in SRDB Ecosystem_state I added some code to say Hopefully that will fix the cases you found |
@ValentineHerr, this doesn't seem to have been completely implemented. For example, citation.ID 28417 has plot name "Mature Subtropical Deciduous Forest. Stand established around 1993" and stand.age=19. |
Thanks for catching that Krista, I had not implemented that correctly. It is now fixed in the "with SRDB" branch. |
@teixeirak, the only cases where there is "Mature" in plot.name now is where age is >=100 or "NAC". Is that ok? |
Yes. |
You can go ahead and merge into the master now. |
Here's a running list of things to check/ fix:
The text was updated successfully, but these errors were encountered: