You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This could be a bug, or it could be a test needing update. Reading api/hooks/issues-hook/update-work-item-priority/index.js, issue priority is treated numerically, and can be compared with higher-priority issues are > than lower-priority.
However, the test code for this passes in priority strings like "P1" and "P2". Strings like these compare the other way around, "P2" > "P1", even though P1 should be higher-priority.
From api/hooks/issues-hook/update-work-item-priority/__test__/updateWorkItemPriority.spec.js,
Resolve this by looking at production logs or GUS api responses, and update either the test code or the implementation code. Consider adding type checking.
The text was updated successfully, but these errors were encountered:
This could be a bug, or it could be a test needing update. Reading
api/hooks/issues-hook/update-work-item-priority/index.js
, issue priority is treated numerically, and can be compared with higher-priority issues are>
than lower-priority.However, the test code for this passes in priority strings like "P1" and "P2". Strings like these compare the other way around,
"P2" > "P1"
, even though P1 should be higher-priority.From
api/hooks/issues-hook/update-work-item-priority/__test__/updateWorkItemPriority.spec.js
,Resolve this by looking at production logs or GUS api responses, and update either the test code or the implementation code. Consider adding type checking.
The text was updated successfully, but these errors were encountered: