Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove logging of Octokit #156

Open
mpsenn opened this issue Feb 14, 2023 · 1 comment
Open

Remove logging of Octokit #156

mpsenn opened this issue Feb 14, 2023 · 1 comment
Labels
USER STORY New feature or request

Comments

@mpsenn
Copy link
Contributor

mpsenn commented Feb 14, 2023

Something seems to be logging the Octokit object for every webhook request. This adds a lot of noise to the app. Remove or improve this log.

"70 <190>1 2023-02-13T23:44:34.994439+00:00 host app web.1 -     teams: {"
"64 <190>1 2023-02-13T23:44:34.994439+00:00 host app web.1 -     },"
"87 <190>1 2023-02-13T23:44:34.994439+00:00 host app web.1 -       updateAlert: [Function]"
"94 <190>1 2023-02-13T23:44:34.994438+00:00 host app web.1 -       listAlertsForRepo: [Function],"
"85 <190>1 2023-02-13T23:44:34.994438+00:00 host app web.1 -       getAlert: [Function],"
"79 <190>1 2023-02-13T23:44:34.994438+00:00 host app web.1 -     secretScanning: {"
"64 <190>1 2023-02-13T23:44:34.994438+00:00 host app web.1 -     },"
"81 <190>1 2023-02-13T23:44:34.994437+00:00 host app web.1 -       users: [Function]"
"83 <190>1 2023-02-13T23:44:34.994437+00:00 host app web.1 -       topics: [Function],"
"82 <190>1 2023-02-13T23:44:34.994437+00:00 host app web.1 -       repos: [Function],"
"83 <190>1 2023-02-13T23:44:34.994437+00:00 host app web.1 -       labels: [Function],"
"98 <190>1 2023-02-13T23:44:34.994436+00:00 host app web.1 -       issuesAndPullRequests: [Function],"
"84 <190>1 2023-02-13T23:44:34.994436+00:00 host app web.1 -       commits: [Function],"
"81 <190>1 2023-02-13T23:44:34.994436+00:00 host app web.1 -       code: [Function],"
"71 <190>1 2023-02-13T23:44:34.994436+00:00 host app web.1 -     search: {"
"64 <190>1 2023-02-13T23:44:34.994436+00:00 host app web.1 -     },"
"94 <190>1 2023-02-13T23:44:34.994435+00:00 host app web.1 -       uploadReleaseAsset: [Function]"
"103 <190>1 2023-02-13T23:44:34.994435+00:00 host app web.1 -       updateWebhookConfigForRepo: [Function],"
"90 <190>1 2023-02-13T23:44:34.994435+00:00 host app web.1 -       updateWebhook: [Function],"
"104 <190>1 2023-02-13T23:44:34.994435+00:00 host app web.1 -       updateStatusCheckProtection: [Function],"
"103 <190>1 2023-02-13T23:44:34.994435+00:00 host app web.1 -       updateStatusCheckPotection: [Function],"
"95 <190>1 2023-02-13T23:44:34.994435+00:00 host app web.1 -       updateReleaseAsset: [Function],"
"90 <190>1 2023-02-13T23:44:34.994434+00:00 host app web.1 -       updateRelease: [Function],"
@git2gus
Copy link

git2gus bot commented Feb 14, 2023

Git2Gus App is installed but the .git2gus/config.json doesn't exist.

@mpsenn mpsenn added the USER STORY New feature or request label Feb 14, 2023
mpsenn pushed a commit that referenced this issue Feb 20, 2023
Remove logging of req object
e571049 
Fixes #156. This log line leads to 2000 lines of unneeded logs for each request. Knowing there's an event match is useful, but we don't need the whole req object, since the webhook body is logged already when the request starts
@mpsenn mpsenn mentioned this issue Feb 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
USER STORY New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove logging of req object forcedotcom/git2gus
1 participant
@mpsenn