Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove calls to console.log #157

Open
mpsenn opened this issue Feb 14, 2023 · 2 comments
Open

Remove calls to console.log #157

mpsenn opened this issue Feb 14, 2023 · 2 comments
Labels
good first issue Good for newcomers USER STORY New feature or request

Comments

@mpsenn
Copy link
Contributor

mpsenn commented Feb 14, 2023

The app has a Winston logger that handles newlines and other logging problems from console.log. Replace any calls to console.log with imports from this class.

https://github.com/forcedotcom/git2gus/blob/main/api/services/Logs/logger.js#L4

@mpsenn mpsenn added USER STORY New feature or request good first issue Good for newcomers labels Feb 14, 2023
@git2gus
Copy link

git2gus bot commented Feb 14, 2023

Git2Gus App is installed but the .git2gus/config.json doesn't exist.

@mpsenn
Copy link
Contributor Author

mpsenn commented Feb 19, 2023

Kind of curious that PRs like #60 removed calls to this service, using console.log instead. I'm finding that multiline logs end up being split by logplex which leads to parsing errors. This is described in sumologic's pages also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers USER STORY New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant