Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent "No valid build found in GUS" error for valid build #90

Open
edmorley opened this issue Aug 5, 2020 · 0 comments
Open

Comments

@edmorley
Copy link
Member

edmorley commented Aug 5, 2020

In heroku/heroku-buildpack-python#1012 after adding the label, Git2Gus commented with:

Error while creating work item. No valid build foundin GUS!

The build specified in .git2gus/config.json was valid. Labels had been added to multiple GitHub issues at once (3-4 issues), and the others were added successfully the first time. Removing and re-adding the label to the linked issue cause the work item to be created successfully.

I believe the GUS API call to resolve the build must have failed for a different reason, but the handling here doesn't take that into account:
https://github.com/forcedotcom/git2gus/blob/dbe8c53c7bf703d7607ca595ef0a473a843eb3b9/api/services/Gus/resolveBuild.js

} else {
console.log(`No correct build for issue titled: ${title}`);
return await updateIssue(req, 'Error while creating work item. No valid build foundin GUS!');

There's also a typo in the error message, "foundin" should be "found in".

Ideally Git2Gus would also retry after a failure, to save having to remove and re-add the label.

edmorley added a commit to heroku/heroku-buildpack-python that referenced this issue Jan 29, 2021
Since the Git2GUS tool has a number of bugs/deficiencies which mean it's
not usable for the time being. If that changes in the future we can add
this configuration back and re-evaluate.

For example:
- forcedotcom/git2gus#97
- forcedotcom/git2gus#90
- forcedotcom/git2gus#91
- forcedotcom/git2gus#92
- forcedotcom/git2gus#86
- forcedotcom/git2gus#15

Closes W-8825462.

[skip changelog]
edmorley added a commit to heroku/heroku-buildpack-python that referenced this issue Jan 30, 2021
Since the Git2GUS tool has a number of bugs/deficiencies which mean it's
not usable for the time being. If that changes in the future we can add
this configuration back and re-evaluate.

For example:
- forcedotcom/git2gus#97
- forcedotcom/git2gus#90
- forcedotcom/git2gus#91
- forcedotcom/git2gus#92
- forcedotcom/git2gus#86
- forcedotcom/git2gus#15

Closes W-8825462.

[skip changelog]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant