Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Enhance check buttons with additional traits automation #333

Open
dylanpiera opened this issue Sep 27, 2023 · 0 comments
Open

Feature: Enhance check buttons with additional traits automation #333

dylanpiera opened this issue Sep 27, 2023 · 0 comments
Labels
feature This issue is a request for a new feature or new functionality pf2e-kingmaker Issues for Pathfinder Kingmaker

Comments

@dylanpiera
Copy link

What happened?

Quoting from discord:

Just checking the Chapter 1 journal, on the 'Black Tears' page the recall knowledge check isn't marked secret, similarly this Seek action on A08 isn't, which seems to be a reoccuring issue on all pages (for search/recall knowledge checks)
So I'm afraid this issue may be persistent through all journals =/
Chapter 3 in "Ambushing the Bandits" similarly recall knowledge is not marked secret, so yeah, probably an issue everywhere.

seekexample
recallknowledgeexample

image
As can be seen here the secret tag is missing as explained they should be in the style guide: https://github.com/foundryvtt/pf2e/wiki/Style-Guide#inline-check-links

What package are you reporting this for?

Pathfinder: Kingmaker

Version

1.0

Relevant log output

No response

@dylanpiera dylanpiera added the bug Functionality which is not working as intended label Sep 27, 2023
@github-actions github-actions bot added the pf2e-kingmaker Issues for Pathfinder Kingmaker label Sep 27, 2023
@silvative silvative changed the title [Bug]: Checks that should be secret aren't (Seek / Recall Knowledge, possible others) Feature: Enhance check buttons with additional traits automation Nov 13, 2023
@silvative silvative removed the bug Functionality which is not working as intended label Nov 13, 2023
@silvative silvative added the feature This issue is a request for a new feature or new functionality label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue is a request for a new feature or new functionality pf2e-kingmaker Issues for Pathfinder Kingmaker
Projects
None yet
Development

No branches or pull requests

2 participants