Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bucket tool changes colors across entire image, not just the selected sprite #23

Closed
VisenDev opened this issue Oct 2, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@VisenDev
Copy link
Contributor

VisenDev commented Oct 2, 2023

When using the bucket tool, it affects the entire image, not just the chosen sprite. I'm not sure if this is intentional behavior or not

@foxnne foxnne added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Oct 3, 2023
@foxnne
Copy link
Owner

foxnne commented Oct 3, 2023

Thanks for the issue! Yes, I had quickly added the bucket tool for myself to use to swap colors for a project I was trying to complete. The bucket tool should be confined to a single tile, but it does change all of the selected color. I need to develop a fill algorithm and get that working so the tool is functional.

@foxnne
Copy link
Owner

foxnne commented Aug 2, 2024

@tnothy 's PR fixes this, I also added an enhancement to contiguous fill on click, and on ctrl/cmd + click replaces all occurrences of a color in a sprite.

@foxnne foxnne closed this as completed Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants