-
Notifications
You must be signed in to change notification settings - Fork 9
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support pecl_http 2.x for compression #30
Comments
Also makes mcrypt & hash optional dependencies and fixes detection of algorithm availability for some algorithms. Note : You should install at least one of mcrypt or hash to at least get a somewhat usable server. Otherwise, the server will lack support for most algorithms and will violate the RFC on required algorithms. Also, only a handful of clients will be able to connect to pssht when it lacks both extensions. Fixes #30.
Just a quick looking around, why not use |
Hi, For compression to work in ssh, a way to flush the compression buffers is required. The flush operation adds synchronization points to the data, which can be used for example by the receiving end to determine when to stop looking for more data to uncompress. The pecl_http extension provides the FLUSH_SYNC flag for that purpose so that a synchronization point is automatically added after each call to the Regarding the current tests failures, they are due to some functional tests where the OpenBSD SSH client is used to establish a connection to a pssht server with varying ciphers. For some reason, this works when I test it locally, but errors out on travis-ci. |
PHP 7.0 added support for incremental compression/decompression (see http://php.net/manual/en/zlib.examples.php), so it may be possible to use this new API to achieve the same result. |
pssht relies on the PECL HTTP extension to provide compression on a stream of data (rather than on a fixed-length buffer).
Currently, the old 1.x branch is the only version supported.
The goal of this ticket is to add support for version 2.x as well to have broader support for compression.
As an alternative, maybe take a look at stream filters to see if it is possible to use them in a streaming mode.
The text was updated successfully, but these errors were encountered: