Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for unused result in calculation simulator/main.cpp : 5411 #122

Open
studiofuga opened this issue May 19, 2018 · 0 comments
Open

Check for unused result in calculation simulator/main.cpp : 5411 #122

studiofuga opened this issue May 19, 2018 · 0 comments
Assignees
Labels
Code Review Code needing review (Warning, code smells)

Comments

@studiofuga
Copy link
Collaborator

This line:

for (unsigned int icl=0; icl <tariff_pop.size();++icl)
                {
                    arbitary_breaks_for_tariff.at(icl) * fmultiplier;
                }

calculates a multiplication but doesn't store the result.
Perhaps it should read:

                    arbitary_breaks_for_tariff.at(icl) *= fmultiplier;
@studiofuga studiofuga added the Code Review Code needing review (Warning, code smells) label May 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Review Code needing review (Warning, code smells)
Projects
None yet
Development

No branches or pull requests

2 participants