-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test new version in fractal-containers #43
Comments
Tested with |
Agreed. I also tested the new http://localhost:3000/vizarr/?source=http://localhost:3000/vizarr/data/data/zarrs/missing-file http://localhost:3000/vizarr/?source=http://localhost:3000/vizarr/data/non-authorized |
Is this how we show the errors? If we get those more explicit errors correctly, can we translate them to something users are more likely to understand. For the 403: Do we know whether the user was logged in without access to that file or just not logged in for that? Can we display corresponding errors with the right hints about what to do? |
The error message is built inside the zarrita.js library. The status code is inserted inside the message. This means that when we receive the message in vizarr we have to parse the string to obtain the status code, which is feasible but not very elegant. It would be better to have a custom error class that contains also a status code field. So, I can add some logic in our fork, but I don't know if that would be merged upstream, since it looks quite related to our specific needs: we can create custom error codes for status that we produce like 500, 404, 401 and 403, but what about all the other possible error codes?
The proper way to do this is returning 401 instead of 403 if the user is not logged in. No problem in adding this. It has to be ignored when |
Let's start with this update. |
Sounds good! :) |
Done in #47 |
Generated again the docker image |
Refs:
The text was updated successfully, but these errors were encountered: