fix: handle empty cached results

frappe · Nov 4, 2023 · dca18f3 · dca18f3
1 parent 1d7b482
commit dca18f3
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/insights/insights/doctype/insights_query/insights_query.py b/insights/insights/doctype/insights_query/insights_query.py
@@ -69,7 +69,7 @@ def results(self):
 
     @property
     def results_row_count(self):
-        return len(CachedResults.get(self.name))
+        return len(self.retrieve_results())
 
     @cached_property
     def variant_controller(self):
@@ -154,7 +154,7 @@ def retrieve_results(self, fetch_if_not_cached=False):
             if fetch_if_not_cached:
                 return self.fetch_results()
             return []
-        return CachedResults.get(self.name)
+        return CachedResults.get(self.name) or []
 
     def fetch_results(self, additional_filters=None):
         self.before_fetch()