Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing font weight Semibold (600) #352

Open
div-Leo opened this issue Aug 11, 2023 · 3 comments
Open

Missing font weight Semibold (600) #352

div-Leo opened this issue Aug 11, 2023 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@div-Leo
Copy link
Contributor

div-Leo commented Aug 11, 2023

We're missing the font weight Semibold = 600

  • @freenow/wave version: latest

Relevant code

fontWeight: 'semibold' // not working

What was expected to happen?

It should render the text with font-weight:600 but is bolder than it should
Expected size:
Screenshot 2023-08-11 at 14 02 01

Reproduction

If you can, try to reproduce the issue in a Codesandbox. You can fork the one
here: https://codesandbox.io/s/wave-playground-forked-fcv8tm?file=/src/App.js

@nlopin nlopin added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Aug 14, 2023
@AditiChikkali
Copy link

could you please assign me this task?

@nlopin
Copy link
Contributor

nlopin commented Feb 7, 2024

I'm considering whether we should include the font in the library 🤔 What is your opinion? I think it removes the whole class of font-loading optimisations which are project-specific

@AditiChikkali
Copy link

I'm considering whether we should include the font in the library 🤔 What is your opinion? I think it removes the whole class of font-loading optimisations which are project-specific

Including the font within the library may limit the ability to optimize font loading, if the font is to be included in the library, can we provide options for users to choose whether to include it or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Development

No branches or pull requests

3 participants