Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to reuse a previously rendered banner after the dismiss transition #376

Open
jonotrujillo opened this issue Sep 19, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@jonotrujillo
Copy link
Member

  • @freenow/wave version: 1.27.0

Relevant code

https://codesandbox.io/s/wave-playground-forked-9hlttk?file=/src/App.js

What was expected to happen?

It should be possible to reuse a previously rendered banner after the transition has ended.

Reproduction

  1. Open the playground: https://codesandbox.io/s/wave-playground-forked-9hlttk?file=/src/App.js
  2. Click on the "add banner" button several times — this will add several elements to the queue
  3. See that the first banner is rendered correctly
  4. Dismiss the shown banner by clicking the "close" button
  5. See that the next banner in queue is not show

  1. As a workaround, enable the key prop of the banner component — retry the steps and see that each element in the queue renders a banner
@martimalek martimalek added the bug Something isn't working label Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants